Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo and add information to Handling quit requests/On mobile devices #9756

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

ztc0611
Copy link
Contributor

@ztc0611 ztc0611 commented Aug 15, 2024

There is a minor typo where the entirety of "Application > Config > Quit On Go Back" is not bolded, and the important information about app process killing on iOS that can be seen in the docs for NOTIFICATION_APPLICATION_PAUSED should likely be pulled into this section.

Both of these changes are relevant to 4.3's docs.

@ztc0611 ztc0611 force-pushed the fix-quit-requests-mobile branch from 1165870 to b6f8733 Compare August 15, 2024 19:57
@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Aug 16, 2024
@skyace65 skyace65 added the platform:ios Issues or PRs related specifically to ios label Sep 5, 2024
@AThousandShips AThousandShips requested a review from a team September 18, 2024 16:35
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple docs:

... approximately five seconds to perform any tasks and return. If the method does not return before time expires, the system may terminate the process altogether.

@mhilbrunner mhilbrunner removed the request for review from a team November 17, 2024 12:53
@mhilbrunner mhilbrunner merged commit b2647dd into godotengine:master Nov 17, 2024
1 check passed
@mhilbrunner
Copy link
Member

Finally managed to merge this, took a while due to the backlog, apologies. Thank you!

@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug platform:ios Issues or PRs related specifically to ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants