Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groups tutorial for project-wide node groups #9461

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Dowsley
Copy link
Contributor

@Dowsley Dowsley commented Jun 6, 2024

godotengine/godot#60965 introduced several changes to how we manage groups in the Editor UI. The Groups dock has had an overhaul and the Groups Editor was removed entirely.

As #9177 points out, this change is yet to be reflected in the documentation. This PR has the intent to be the first step towards this.

Please let me know how I can improve the writing, or any further page that should also change.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jun 7, 2024
@skyace65 skyace65 added this to the 4.3 milestone Jun 7, 2024
tutorials/scripting/groups.rst Outdated Show resolved Hide resolved
tutorials/scripting/groups.rst Outdated Show resolved Hide resolved
tutorials/scripting/groups.rst Outdated Show resolved Hide resolved
@Dowsley Dowsley force-pushed the updated-groups-tutorial branch 2 times, most recently from 70c4224 to 6f0b105 Compare June 7, 2024 14:23
@AThousandShips AThousandShips requested a review from a team June 7, 2024 14:24
@Dowsley Dowsley requested a review from AThousandShips June 7, 2024 14:25
@Dowsley
Copy link
Contributor Author

Dowsley commented Jun 7, 2024

Fixed in a force-pushed amend. Is it recommended that I add a new commit for fix next time?

@AThousandShips
Copy link
Member

No we prefer single commits!

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style itself looks good, will await some approval on content as well

@Dowsley
Copy link
Contributor Author

Dowsley commented Jun 9, 2024

The style itself looks good, will await some approval on content as well

Thanks. Yes there anybody I can tag here or should I wait for a contributor to pick it?

@AThousandShips
Copy link
Member

Relevant team is already requested for review

@skyace65 skyace65 merged commit bf8c53b into godotengine:master Jun 16, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants