Update the Emscripten minimum requirements to 3.1.39 #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
changed the title
akien-mga
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Technically earlier versions can still work, but I don't know how far back.
So it's fine as is, but we might want to clarify this in case someone really needs to use e.g. 3.1.20 for some reason, which would still work.
I think the min requirement for GDExtension support is 3.1.14, but for users who don't care about dynamic loading it may work with older versions too.
I could add a comment about this, yes. |
adamscott
force-pushed
the
update-emscripten-minimum-requirements
branch
from
3828b41 to
b3926b9
Compare
skyace65
approved these changes
Feb 5, 2024
|
Thanks! |
mhilbrunner
pushed a commit
that referenced
this pull request
May 7, 2024
…uirements Update the Emscripten minimum requirements to 3.1.39 (cherry picked from commit 7f531fe)
|
Cherrypicked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8589
Recommending 3.1.39 as this is our current battle-tested version.