Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Fix typo in importing_images.rst ("Rougness" should be "Roughness") #8681

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[Minor] Fix typo in importing_images.rst ("Rougness" should be "Roughness") #8681

merged 1 commit into from
Dec 28, 2023

Conversation

GreentheNinja
Copy link
Contributor

No description provided.

@GreentheNinja GreentheNinja changed the title [Minor] Fix typo "Rougness" (should be "Roughness") [Minor] Fix typo in importing_images.rst ("Rougness" should be "Roughness") Dec 25, 2023
AThousandShips
AThousandShips reviewed Dec 26, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underline must match the heading

When fixing this please do so with git commit --amend if you are using the command prompt, or squash your commits into one

tutorials/assets_pipeline/importing_images.rst Outdated
@@ -381,7 +381,7 @@ Roughness > Mode
The color channel to consider as a roughness map in this texture. Only effective if
**Roughness > Src Normal** is not empty.

Rougness > Src Normal
Roughness > Src Normal
^^^^^^^^^^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed, I hope I did that right?

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation topic:import labels Dec 26, 2023
@skyace65 skyace65 merged commit 29294ee into godotengine:master Dec 28, 2023
1 check passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

mhilbrunner pushed a commit that referenced this pull request Jan 25, 2024
@skyace65 @mhilbrunner
Merge pull request #8681 from GreentheNinja/patch-1
f41acbe 
[Minor] Fix typo in `importing_images.rst` ("Rougness" should be "Roughness")
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

@GreentheNinja GreentheNinja deleted the patch-1 branch June 21, 2024 09:18
@GreentheNinja GreentheNinja restored the patch-1 branch June 21, 2024 09:20
@GreentheNinja GreentheNinja deleted the patch-1 branch June 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 content:proofreading Issues and PRs related to proofreading the documentation topic:import
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GreentheNinja @skyace65 @mhilbrunner @AThousandShips