Improve code style for cross-language scripting examples #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
topic:dotnet
area:manual
paulloz
reviewed
Oct 9, 2023
wlsnmrk
force-pushed
the
cross-scripting-style
branch
2 times, most recently
from
939aaf3 to
9f0c985
Compare
|
This is still waiting for a merge 🙏 |
AThousandShips
approved these changes
May 8, 2024
wlsnmrk
force-pushed
the
cross-scripting-style
branch
from
9f0c985 to
e16be0a
Compare
|
Thanks for the review! While checking my changes, I noticed that C# lines casting arrays to |
|
Ooh, good spot! Yes, that warning block is no longer relevant. |
* Replaced "foo"/"bar" example values with "my value". * Changed C# public field to property and GDScript to match. * Used PascalCase for C# property. * Used camelCase for C# local variable. * Used "var" for C# local variable declarations. * Used PascalCase for GDScript class/script variable. * Improved clarity of comments documenting expected output. * Eliminated horizontal scroll in C# code example. * Fixed a comma splice in the page text. * Removed an out-of-date warning block.
wlsnmrk
force-pushed
the
cross-scripting-style
branch
from
e16be0a to
aa223c3
Compare
|
Thanks! Fixed. |
paulloz
approved these changes
May 20, 2024
mhilbrunner
approved these changes
Nov 19, 2024
|
Thank you! Merged. Finally. :) Oof, this took a while, apologies, somehow this PR slipped through. In the future, feel free to ping us if nothing moves for weeks. |
|
Cherrypicked to 4.3 in #10347. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated C# and GDScript code examples in the cross-language scripting docs, to (hopefully) improve clarity and better match the respective code styles.
Specifically: