Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NavigationObstacle API doc #7495

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Jun 10, 2023

Updates NavigationObstacle API doc.

Godot 4.1 only.

Update for when PR godotengine/godot#78081 gets merged.

Updates NavigationObstacle API doc.
@mhilbrunner mhilbrunner added this to the 4.1 milestone Jun 11, 2023
@mhilbrunner mhilbrunner added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jun 11, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Jun 11, 2023

One consideration is that everything in code blocks is not translated for docs translations.

It may make sense to have "For 2D"/"For 3D" formatted above the code blocks as small headers or even just bolded text, what do you think?

Likewise, prefer keeping descriptions of what the code is doing next to the code instead of as comments in the code, although thats a case-by-case (or comment-by-comment) decision, short comments are generally fine :)

@smix8
Copy link
Contributor Author

smix8 commented Jun 11, 2023

I would preferred "extends Node2D/3D" in the first line to signal that the code snippet is for 2D or 3D because it creats a highlight color in the code instead of they greyed comment color. There are users regularly that do not understand this. They think the code snippet is broken because they try to do a direct 1:1 copy of the code into their projects.

Not sure, most comments, when placed next to the code, become hard to read due to line length/wrap in my browser.

Maybe there should be a special syntax for code-snippets lines that adds them to the translation strings.

@skyace65 skyace65 merged commit 4b089d5 into godotengine:master Jun 25, 2023
@skyace65
Copy link
Contributor

Thanks!

@smix8 smix8 deleted the doc_navigationobstacle_api_4.x branch June 26, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants