Update NavigationAgent doc for avoidance rework #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
update_navagent_doc_4.x
branch
from
a06fc7b to
73730b8
Compare
mhilbrunner
added
enhancement
area:manual
mhilbrunner
reviewed
May 18, 2023
smix8
force-pushed
the
update_navagent_doc_4.x
branch
from
73730b8 to
1502b20
Compare
mhilbrunner
approved these changes
May 18, 2023
smix8
force-pushed
the
update_navagent_doc_4.x
branch
from
1502b20 to
ab90602
Compare
Updates NavigationAgent doc for avoidance rework.
smix8
force-pushed
the
update_navagent_doc_4.x
branch
from
ab90602 to
cf9760d
Compare
|
Thank you! 🎉 |
Comment on lines
+17
to
+19
| The functionality of NavigationsAgent nodes can be recreated with scripts and direct | ||
| calls to the NavigationServer API should the default NavigationsAgent | ||
| nodes not do what is required for a project and specific gameplay. |
There was a problem hiding this comment.
@smix8 sorry for tagging you on something what's already merged. Is this sentence phrased as really intended? I dont understand what does it mean circa from the word "should" on second line...
There was a problem hiding this comment.
It means to role your own agent implementation if the default does not what you need as the NavigationAgent node is optional to work with the navigation system. That block was a copy&paste from the existing doc with not much thought behind. Could be reworded, there are also smaller typos to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks NavigationAgent doc for changes in avoidance rework pr godotengine/godot#69988.
Docs team: this is 4.1+