Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C# code examples (salvage of VinnNo's PRs) #5249

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add C# code examples (salvage of VinnNo's PRs) #5249

merged 1 commit into from
Apr 29, 2022

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Sep 13, 2021 •
edited
Loading

This PR is mostly salvages of @VinnNo's PRs that add C# code examples, with lots of changes. It also updates the GDScript docs in a few places, targeting Godot 4.0.

3.x version (already merged): #5250

@YuriSizov
Copy link
Contributor

The build fails because the class reference hasn't been updated for Godot 4.0 yet. We should do that soon anyway...

Let's mark this as draft until then?

@aaronfranke aaronfranke marked this pull request as draft September 13, 2021 13:10
@aaronfranke aaronfranke mentioned this pull request Oct 3, 2021
Merged
@mhilbrunner mhilbrunner added the needs work Needs additional work by the original author, someone else or in another repo. label Nov 3, 2021
@aaronfranke aaronfranke marked this pull request as ready for review December 19, 2021 02:45
@aaronfranke aaronfranke removed the needs work Needs additional work by the original author, someone else or in another repo. label Dec 19, 2021
@aaronfranke
Copy link
Member Author

Since the class reference has been updated, I'm setting this as ready for review again.

@mhilbrunner mhilbrunner self-requested a review December 29, 2021 17:27
akien-mga
akien-mga approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, then should be fine to merge I believe.

@akien-mga akien-mga mentioned this pull request Apr 29, 2022
Closed
@aaronfranke aaronfranke added this to the Godot 4.0 milestone Apr 29, 2022
@aaronfranke aaronfranke merged commit 82e5e45 into godotengine:master Apr 29, 2022
@aaronfranke aaronfranke deleted the salvage-vinnno branch April 29, 2022 22:46
@raulsntos raulsntos mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@mhilbrunner mhilbrunner Awaiting requested review from mhilbrunner

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronfranke @YuriSizov @akien-mga @mhilbrunner