Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document iOS plugins #4213

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

NathanLovato
Copy link
Contributor

@NathanLovato NathanLovato commented Oct 6, 2020

I started editing the iOS plugin docs. It requires merging godotengine/godot#41230 first so I didn't finish editing yet. The long nested bullet list still needs review and splitting.

Includes and supersedes #4194; I couldn't push edits to the original PR.

@NathanLovato NathanLovato added the content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features label Oct 6, 2020
@NathanLovato NathanLovato self-assigned this Nov 26, 2020
@akien-mga
Copy link
Member

The feature has been merged in master, so this can be rebased and merged.

@NathanLovato
Copy link
Contributor Author

Sure, it's on my to-do list. If I haven't merged yet, it's because there's a good deal of editing left.

@akien-mga
Copy link
Member

Note that the feature has also been merged in 3.2, so we'll need to merge this and cherry-pick before releasing 3.2.4-stable.

@akien-mga akien-mga self-assigned this Jan 16, 2021
@NathanLovato
Copy link
Contributor Author

Sorry for not tackling this one. Since december, I'm playing catch up with work. I've done some of the work editing the original document, just not all, but merging as-is might be fine.

If that's fine by you, I can remove conflicts and merge in the doc's current state after vacation, on Thursday or Friday.

@NathanLovato NathanLovato merged commit bb8013b into godotengine:master Jan 21, 2021
@NathanLovato NathanLovato deleted the feature/ios-plugin branch January 21, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants