Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Update platform support for 4.4 and new minimum required TFM #10427

Merged
merged 1 commit into from
Dec 20, 2024
Merged

C#: Update platform support for 4.4 and new minimum required TFM #10427

merged 1 commit into from
Dec 20, 2024

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added enhancement topic:dotnet area:about Issues and PRs related to the About section of the documentation and other general articles area:getting started Issues and PRs related to the Getting Started section of the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation platform:android labels Dec 19, 2024
tetrapod00
tetrapod00 reviewed Dec 19, 2024
View reviewed changes
about/list_of_features.rst Outdated Show resolved Hide resolved
tutorials/scripting/c_sharp/index.rst Outdated Show resolved Hide resolved
tutorials/scripting/c_sharp/index.rst Show resolved Hide resolved
@raulsntos
C#: Update platform support for 4.4 and new minimum required TFM
62b342b 
- Remove Android restrictions that no longer apply in 4.4.
- Add links in the C# documentation about general upstream system requirements that also apply to C# projects.
- Godot projects now target `net8.0`, so there's no need to mention TFM requirements in platform support. And we can update every mention of .NET 6 with .NET 8 and C# 10 with C# 12.
@raulsntos raulsntos force-pushed the dotnet/changes-in-4.4 branch from 14f6274 to 62b342b Compare December 19, 2024 19:53
tetrapod00
tetrapod00 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming correctness, LGTM

@tetrapod00 tetrapod00 added this to the 4.4 milestone Dec 19, 2024
@raulsntos raulsntos mentioned this pull request Dec 19, 2024
Merged
@mhilbrunner mhilbrunner merged commit 6d5fd9a into godotengine:master Dec 20, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you, and thanks for keeping the C# docs up to date! Merged.

@raulsntos raulsntos deleted the dotnet/changes-in-4.4 branch December 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetrapod00 tetrapod00 tetrapod00 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:about Issues and PRs related to the About section of the documentation and other general articles area:getting started Issues and PRs related to the Getting Started section of the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement platform:android topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @mhilbrunner @tetrapod00