Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase dictionary description in Advanced GDScript #10413

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

tetrapod00
Copy link
Contributor

Resolves #8435. Avoids the incorrect claim that Dictionaries don't exist in C++/C#, and avoids unnecessary hostility and any mention of specific other languages at all.

I don't really know if this is the ideal way to rephrase this. This whole section kind of needs a rewrite anyway, since it partially duplicates GDScript Reference / Dictionary, and also needs to at least mention typed dictionaries.

@tetrapod00 tetrapod00 added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 labels Dec 15, 2024
@mhilbrunner mhilbrunner merged commit 47d39d9 into godotengine:master Dec 16, 2024
1 check passed
@mhilbrunner
Copy link
Member

Certainly an improvement :) Thanks.

@tetrapod00 tetrapod00 deleted the be-nice-to-c branch December 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inaccurate claim that c#/c++ devs tend to not use dictionaries
2 participants