-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Briefly document Vector<> variations #10382
Conversation
Please do check my understanding is correct - this is based off my reading of the source, and commentary from #10329, but there may be nuances which I'm missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving only for style, and for not seeing anything obviously wrong from my casual understanding of the Godot codebase.
It's good to go as long as it is correct, IMO.
Cheers for all the reviews, and sorry about the delay! I should be able to take another look at this tonight. |
@esainane no rush, but are you planning to continue working on this? |
`Packed*Array` aliases seem universally preferred where available, so a link to the list of types seems appropriate. `LocalVector` is used sparingly, so mentioning the intent and rough tradeoff involved seems right for an overview.
See discussion in PR#10382.
5fb32b4
to
24acaa1
Compare
Sorry for the delay; we live in rather interesting times. :| I've fully rebased the PR, and tried to incorporate all of the feedback. Current |
Co-authored-by: A Thousand Ships <[email protected]>
91552ef
to
6db14b4
Compare
I suspect this would read better if moved to the "Containers" section which immediately follows "Allocating memory", but wanted to provide an update for existing feedback first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct information-wise now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar and spelling wise everything looks good
Thanks! |
This continues #10329.
Packed*Array
aliases seem universally preferred where available, so a link to the list of types seems appropriate.LocalVector
is used sparingly, so mentioning the intent and rough tradeoff involved seems right for an overview.Bugsquad edit: closes #6259.