Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nim GDExtension #10366

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Add Nim GDExtension #10366

merged 1 commit into from
Dec 6, 2024

Conversation

xix-xeaon
Copy link
Contributor

I've been testing the extension for a few different things which have worked well and it has an active developer so I think it can be added to the list.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval in theory. Someone from GDExtension needs to confirm that is considered well-developed enough to be added.

@tetrapod00 tetrapod00 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension labels Dec 4, 2024
@tetrapod00 tetrapod00 requested review from paddy-exe and a team December 4, 2024 22:07
@dsnopek
Copy link
Contributor

dsnopek commented Dec 6, 2024

Someone from GDExtension needs to confirm that is considered well-developed enough to be added.

I don't know that anyone on the GDExtension team has directly used the Nim binding, and the developer hasn't (to my knowledge) been in contact with the team either. Given that I don't personally know Nim, and the binding itself is written in Nim (as opposed to being written in C or C++, which sometimes is the case), it's hard to review it. :-)

Poking around on GitHub, it appears the current Nim binding is a continuation of this project, which has been around since May 2023. The two projects have 58 and 73 stars, respectively. That's smaller than the Nim GDNative bindings for Godot 3 which goes back many more years and has ~500 stars, but that still seems fairly promising to me?

I'd probably err on the side of including it.

@mhilbrunner mhilbrunner merged commit d2ae3e5 into godotengine:master Dec 6, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdextension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants