Add information on web export splash color in custom HTML shells #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpozewaunig
changed the title
tetrapod00
reviewed
Nov 22, 2024
tetrapod00
added
enhancement
area:manual
Additionally linked to project settings exposed as placeholder variables
elpozewaunig
force-pushed
the
web_splash_color
branch
from
1ffb82c to
1e31d21
Compare
tetrapod00
approved these changes
Nov 23, 2024
mhilbrunner
approved these changes
Nov 23, 2024
AThousandShips
changed the title
|
Also, thank you for coming back to document your changes in the online manual. The PR process only really requires that new changes be documented in the class reference, so new features go undocumented fairly often. Really appreciate the effort here! |
skyace65
approved these changes
Nov 29, 2024
|
Merging this PR without a web team review as this extremely straightforward, and documented by the person who implemented it in the engine. Thanks for your work elpozewaunig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the mention of the new placeholder introduced in godotengine/godot#96625, which allows custom HTML shells to directly use the Project Settings splash color.