Update PackedArray explanation to match Godot 4.0 behavior #10304
Conversation
tetrapod00
added
enhancement
topic:gdscript
area:manual
clayjohn
added
bug
cherrypick:4.2
cherrypick:4.3
enhancement
and removed
enhancement
labels
Co-authored-by: tetrapod <[email protected]>
Co-authored-by: tetrapod <[email protected]>
|
Thank you! Congratulations on your first merged documentation contribution 🎉 |
|
I apologise for asking this but it seems github did not respect my email choice from my original commits and commited using an email that isn't supposed to be used for commits. If it's not a huge risk and pain, is it possible to amend the final commit or redo it? I have since set my email to private. I don't care about the commit being associated with my account. I know it's a lot to ask so if it's not something that's doable without risk, then it's fine to leave it as is. |
|
@mechalynx I'm not actually sure, I asked in the contributors chat. |
|
Deepest of thanks. Again, if it's too risky, it's ok. |
Add paragraphs describing the differences between PackedArray and normal or typed Array. --------- Co-authored-by: tetrapod <[email protected]>
|
I amended the commit to use the anonymized GitHub email: https://github.com/godotengine/godot-docs/commit/0f8c24b071bba7f7955f1c8cb8c0fa30003f0d81.patch This is a destructive operation that requires a force push so normally not something we'd do, but here it was still the latest commit and no new PR had been opened in the meantime, so it shouldn't cause too much trouble. |
|
Thankyou. I did not expect you to go to the lengths to even replace it with the anyonymized version which is more than kind on your part. I understand the nature of the operation and that it was presumptuous to ask for this in the first place, especially for a repository of this size and scope. It being the last commit was what made me decide to ask but I still feel deeply embarassed for having to do so. I understand this was likely a stressful decision and I am very sorry for the trouble. If necessary, I can delete my comments related to this, if there is concern that it might give the wrong idea about project policy. I looked into this and it seems github at some point added a dropdown to select email used for merge commits in 2019 but since at least 2022 it seems the option is gone again. The commits on my fork branch had the email I chose and I assumed it would use that one but it instead used my primary. I have since changed email to private and use the anonymized one in my local git installation. Thanks again and sorry. |
|
No worries, shit happens, especially if something as complex as Git is involved :) Thanks for contributing! |
Add paragraphs describing the differences between PackedArray and normal or typed Array. --------- Co-authored-by: tetrapod <[email protected]>
|
Cherrypicked to 4.3 in #10347. |
Closes #10300