Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back information about per-vertex shading #10281

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Nov 18, 2024

Documentation for godotengine/godot#83360.

Rather than use the existing screenshots from prior docs versions, I took new ones at higher resolution.

I also re-took the brick cube screenshot for this section, using a CC0 bricks texture from AmbientCG. But we might want to revert that since now this section does not match the rest of this page. Should AmbientCG be credited here in the image caption?

This whole page kind of needs a rewrite with all new screenshots, so I'm not particularly worried about introducing a little more visual inconsistency.

I did my best to search the rest of the docs for "vertex shading" and variations, and this is all I could find.

I'm not all that attached to the rewrite I did here. We could also start from the 4.1 version of the page (which still has info about vertex shading) and make very minor changes.

@tetrapod00 tetrapod00 added topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:3d labels Nov 18, 2024
@tetrapod00 tetrapod00 added this to the 4.4 milestone Nov 18, 2024
@tetrapod00 tetrapod00 requested a review from a team November 18, 2024 02:44
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mhilbrunner mhilbrunner merged commit 5bad2a6 into godotengine:master Nov 18, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@tetrapod00 tetrapod00 deleted the vertex-shading branch November 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants