Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar and writing in Pipeline compilations page #10257

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 13, 2024

  • Mention example of off-screen rendering using ColorRect to hide the root viewport's 3D rendering or a SubViewport node.
  • Split into more paragraphs to improve readability.
  • Link to class reference pages when relevant.
  • Use sentence case for headings to match the rest of the documentation.
  • Wrap source file to 80 characters like other pages.

- Mention example of off-screen rendering using ColorRect to hide
  the root viewport's 3D rendering or a SubViewport node.
- Split into more paragraphs to improve readability.
- Link to class reference pages when relevant.
- Wrap source file to 80 characters like other pages.
@Calinou Calinou added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Nov 13, 2024
@mhilbrunner
Copy link
Member

Wrap source file to 80 characters like other pages.

For the future, this is probably worth doing in a separate commit, because it makes reviewing changes in Github's diff painful, even when set to ignore whitespace.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change is optional, the rest (still) looks good

tutorials/performance/pipeline_compilations.rst Outdated Show resolved Hide resolved
@mhilbrunner mhilbrunner merged commit 703d0cd into godotengine:master Nov 15, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks!

@tetrapod00 tetrapod00 added this to the 4.4 milestone Nov 22, 2024
@Calinou Calinou deleted the improve-pipeline-compilations branch December 2, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants