Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change warning boxes to danger boxes if data loss can occur #10252

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Change warning boxes to danger boxes if data loss can occur #10252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/development/core_and_modules/custom_platform_ports.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ you have two options:
Distributing a custom platform port
-----------------------------------

.. warning::
.. danger::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the same standard of potential legal harm used to change this warning, the warning in Complying with licenses could also be a danger:

godot-docs/about/complying_with_licenses.rst

Lines 8 to 12 in 905b1f4

.. warning::
The recommendations in this page **are not legal advice.** They are provided
in good faith to help users navigate license attribution requirements.

However, that one occurs early in the docs in the About section, so a danger might scare people off. And I think the potential harm of getting the MIT license a little wrong is less than the potential harm of distributing an NDA console port 🤷


Before distributing a custom platform port, make sure you're allowed to
distribute all the code that is being linked against. Console SDKs are
Expand Down
2 changes: 1 addition & 1 deletion contributing/workflow/bisecting_regressions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ whether the issue is a regression in 4.0 or not.
- If the issue is **not present** in 3.x, then you can try older 4.0 alphas and
betas to determine when the regression started.

.. warning::
.. danger::

Project files may be incompatible between Godot versions.
**Make a backup of your project** before starting the bisection process.
Expand Down
2 changes: 1 addition & 1 deletion tutorials/migrating/upgrading_to_godot_4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ only ``.gdshader`` is supported in Godot 4.0.
Running the project upgrade tool
--------------------------------

.. warning::
.. danger::

**Make a full backup of your project** before upgrading! The project upgrade
tool will *not* perform any backups of the project that is being upgraded.
Expand Down
2 changes: 1 addition & 1 deletion tutorials/networking/http_request_class.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ For example, to set a custom user agent (the HTTP ``User-Agent`` header) you cou
HttpRequest httpRequest = GetNode<HttpRequest>("HTTPRequest");
httpRequest.Request("https://api.github.com/repos/godotengine/godot/releases/latest", new string[] { "User-Agent: YourCustomUserAgent" });

.. warning::
.. danger::

Be aware that someone might analyse and decompile your released application and
thus may gain access to any embedded authorization information like tokens, usernames or passwords.
Expand Down
4 changes: 2 additions & 2 deletions tutorials/plugins/running_code_in_the_editor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use cases:
- If your player doesn't use a sprite, but draws itself using code, you can make
that drawing code execute in the editor to see your player.

.. DANGER::
.. danger::

``@tool`` scripts run inside the editor, and let you access the scene tree
of the currently edited scene. This is a powerful feature which also comes
Expand Down Expand Up @@ -503,7 +503,7 @@ currently focused on the script editor.

Scripts that extend EditorScript must be ``@tool`` scripts to function.

.. warning::
.. danger::

EditorScripts have no undo/redo functionality, so **make sure to save your
scene before running one** if the script is designed to modify any data.
Expand Down