Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about LightmapGI only baking nodes under its parent #10247

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

FlooferLand
Copy link
Contributor

@FlooferLand FlooferLand commented Nov 11, 2024

LightmapGI's documentation currently doesn't mention the fact it only bakes nodes under its parent.
This can make the user think there is something wrong with their scene setup or 3D models, as it refuses to bake when the user's models / world isn't under the same parent as the LightmapGI.

I personally encountered this issue because I tried adding a LightmapGI underneath a blank node called "Environment" under which a WorldEnvironment was also present, and the LightmapGI complained about having nothing to bake.

Made for the #9694 issue
Linked class reference PR: godotengine/godot#99079

`LightmapGI`'s documentation currently doesn't mention the fact it only bakes nodes under its parent.
This can make the user think there is something wrong with their scene setup or 3D models, as it refuses to bake when the user's models / world isn't under the same parent as the `LightmapGI`.
@tetrapod00 tetrapod00 added topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Nov 14, 2024
@mhilbrunner mhilbrunner merged commit d7ba911 into godotengine:master Nov 17, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants