Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GDScript format strings tutorial #10227

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

tetrapod00
Copy link
Contributor

  • Remove usages of "integral". The adjective "integral" is pretty much only used on this page. While "integral number" is technically more correct, "integer" is a much more commonly understood word. The rest of the docs already uses "integer number" or "integer value" for similar cases.
  • Add section on string concatenation. Since this page already compares two ways of modifying strings, this one should be mentioned too.
  • Improve organization. Information about the format() function was interleaved in a confusing way. I extracted it out to its own section. The introduction to format strings was also simplified.
  • Fix incorrect examples. A couple examples in the format() example table did not match their listed output.

Arguably this page should also be renamed, but I think that will break things?

Remove usages of "integral".
Add section on string concatenation.
Improve organization.
Fix incorrect examples.
@mhilbrunner mhilbrunner added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 labels Nov 7, 2024
@mhilbrunner mhilbrunner merged commit 396fc8f into godotengine:master Nov 7, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks! Merged.

@tetrapod00 tetrapod00 deleted the integral-integer branch November 7, 2024 23:26
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants