Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Editor Icons page to reflect usage of svgo #10195

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

tetrapod00
Copy link
Contributor

Closes #9769.

After godotengine/godot#92766, icons can now be optimized automatically by the pre-commit hook.

@tetrapod00
Copy link
Contributor Author

CC @Repiteo - Is there anything else that needs to be documented about using svgo with the pre-commit hook?

@tetrapod00 tetrapod00 changed the title Update Editor Icons page to reflect usage of svgo Update Editor Icons page to reflect usage of svgo Nov 3, 2024
@Piralein Piralein added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation cherrypick:4.3 labels Nov 3, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Nov 4, 2024

Is there anything else that needs to be documented about using svgo with the pre-commit hook?

Not particularly, no. A simple notice like you've done here should do the trick

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 1523dcd into godotengine:master Nov 4, 2024
1 check passed
mhilbrunner pushed a commit that referenced this pull request Nov 30, 2024
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Editor icons" page is outdated
5 participants