Add diagram of shader compilation steps to Pipeline Compilations page #10144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
area:manual
|
Diagram uses "Godot Shading Language". If godotengine/godot#97298 is approved, this will need changes. |
tetrapod00
force-pushed
the
pipeline-stutter-diagram
branch
from
b2720a4 to
396f38f
Compare
clayjohn
approved these changes
Nov 6, 2024
mhilbrunner
approved these changes
Nov 17, 2024
tetrapod00
force-pushed
the
pipeline-stutter-diagram
branch
from
396f38f to
991cea2
Compare
|
Rebased. |
|
Nice! In this goes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #10007 (comment).
I don't think any actual changes are needed to the paragraph below, although they could be made.
Diagram made with draw.io. Colors were picked from existing docs theme. Font is Noto Sans.
PNG preview of diagram. Note that the actual webp used in the PR looks slightly different due to a different export process:
PNG preview alternate, with "GDShader" instead of "Godot Shading Language":
PNG alternate, with colors picked from the editor instead of the docs. It's not bad, but it's dull.
Source for diagram:
shader_compilation.drawio.xml.zip
Aesthetic feedback on these diagrams is also appreciated.