-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev_build and dev_mode flags to SCons compilation instructions for desktop editor pages #10019
Conversation
For @bruvzg 's mention on The dev_build parameter being the specific one making sure the debug symbols are included and dev_mode doing something slightly different, I'm assuming I should modify the documentation to reflect what each parameter does specifically? |
Alternatively, I could just put a link to the Introduction page's development and production aliases headline: https://docs.godotengine.org/en/stable/contributing/development/compiling/introduction_to_the_buildsystem.html#development-and-production-aliases This entire PR stems from the idea that many first-time contributors skip the Introduction documentation and go directly to their personal platform's installation instructions. Any ideas on the best way to give them the information they need as unobtrusively as possible? |
This probably is a better option, and will avoid unnecessary duplication of the same info on multiple pages. |
What about another tip or note box, just before or after the one about the one about
(The section for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested the current wording for the tip boxes, so I approve this addition. I think it's a net improvement to the pages. It does need one more change to use internal link syntax.
In the future we should probably do something to address the accumulation of tip and note boxes in these pages, but since they are out-of-the-way contributing pages, it seems fine.
Oh, and ideally you'll squash all your commits into a single commit. We have a short tutorial on that here if you're unfamiliar.
@jonathansekela Not sure if you're still working on changes, but you still need to add an anchor to the section heading that is being linked to. (The internal link syntax doesn't automatically generate one, we have to add them manually whenever we link from other pages) Ah, and this definitely does need a rebase now. You can use that linked tutorial on squashing |
3a82882
to
62327ef
Compare
62327ef
to
e081912
Compare
dear god everyone saw that too I'm so sorry, that was an abysmal showing on my part. I'm not quite sure what went wrong, but something definitely went wrong when I tried to rebase. I promise I tried to follow the instructions, but obviously not very well. I finally managed to get my fork of godot-docs squashed down to one commit. I'll continue by adding the anchor to the section heading. |
It's okay, it's not very straightforward the first time you do it. I've messed up my share of rebases too. Looks like you got to a single squashed commit. FYI now that you have a single commit (and in future PRs), you can use an amend workflow as an alternative to multiple commits and squashing. |
…r desktop editor pages
26647f4
to
9057f15
Compare
Alright, my fork should be ship-shape and ready for review now. I figured out why my amend didn't work as well - I was syncing, not force-pushing. Please let me know if you see anything else that might be a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to give other maintainers a chance to look this over before merging, but this looks good to me 👍
Merged. Thanks and congrats on your first merged contribution! |
Cherrypicked to 4.3 in #10347. |
Closes #10018. Bugsquad edit: link to the issue so it auto-closes
Add instructions to compile SCons with dev_build=yes and dev_mode=yes flags to desktop documentation pages.