-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add One Way Collision for 2D Physics tests #573
Merged
aaronfranke
merged 1 commit into
godotengine:master
from
nekomatata:physics-test-one-way-collision
Jan 7, 2021
Merged
Add One Way Collision for 2D Physics tests #573
aaronfranke
merged 1 commit into
godotengine:master
from
nekomatata:physics-test-one-way-collision
Jan 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
requested changes
Jan 6, 2021
pouleyKetchoupp
force-pushed
the
physics-test-one-way-collision
branch
2 times, most recently
from
January 7, 2021 00:13
c616fcd
to
f265275
Compare
Thanks @aaronfranke! I've updated the test from all your suggestions. |
pouleyKetchoupp
force-pushed
the
physics-test-one-way-collision
branch
from
January 7, 2021 02:02
f265275
to
b4cae9e
Compare
I've just added proper support for |
aaronfranke
reviewed
Jan 7, 2021
pouleyKetchoupp
force-pushed
the
physics-test-one-way-collision
branch
from
January 7, 2021 03:25
b4cae9e
to
6a738c1
Compare
aaronfranke
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 2D Physics tests with a new demo to test one way collision.
This test scene is inspired by the "Around the Clock" test made by @madmiraal in https://github.com/madmiraal/godot-gym in order to test this PR: godotengine/godot#42574
Like the original test, it allows testing collision between a rigid/kinematic body object and a one-way collision platform at different angles.
This new version is a bit different to be able to use it in a more practical way within the physics test framework:
Overall, the idea is to be able to test a set of parameters in less than a minute, check the log for failed cases and test these failed cases easily.
@madmiraal I think it covers the same cases as your original test, but if you have some time to have a look, please let me know in case I overlooked something.