Allow method binds to take Object subclasses as arguments #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As done in upstream Godot via GH-57205. Add a test that ensures it works also for "gdextended" objects.
Faless
added
bug
akien-mga
approved these changes
Jan 10, 2023
|
#950 Anyway, this PR does not fix |
|
Sorry about that. We have a lot of PRs to review both on upstream Godot and here, it's difficult to be up-to-date on everything. If you can rebase your PR, the remaining changes you have there seem useful indeed. |
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done in upstream Godot via GH-57205.
Add a test that ensures it works also for "gdextended" objects.
See godotengine/godot#57205