[SCons] Unify tools/target build type configuration #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
added
enhancement
I haven't checked the PR in detail yet but this seems wrong to me. Upstream And this is used throughout core code so code ported from upstream Godot should keep the same convention. |
Ah, my bad, I thought it was an extension specific define. I reverted the commit. |
Faless
force-pushed
the
build/4.x_unify_targets
branch
from
de29a38 to
a746843
Compare
Faless
force-pushed
the
build/4.x_unify_targets
branch
from
a746843 to
b4ea6e1
Compare
Faless
changed the title
akien-mga
reviewed
Oct 4, 2022
akien-mga
reviewed
Oct 4, 2022
akien-mga
reviewed
Oct 4, 2022
test/demo/bin/libgdexample.osx.template_debug.framework/Resources/Info.plist
Outdated
Show resolved
Hide resolved
akien-mga
reviewed
Oct 4, 2022
akien-mga
reviewed
Oct 4, 2022
Faless
force-pushed
the
build/4.x_unify_targets
branch
2 times, most recently
from
d3401a6 to
4dad7f4
Compare
Now matches Godot `master` target names and supports the same flags with the following notable exceptions: - The default target is "template_debug", since it's compatible with editor builds (and TOOLS_ENABLED is never used internally). - separate_debug_symbols is still not supported, and will be done in a separate commit.
Faless
force-pushed
the
build/4.x_unify_targets
branch
from
4dad7f4 to
64b2c9b
Compare
akien-mga
approved these changes
Oct 4, 2022
|
Thanks! |
|
In relation to this issue: codecat/godot-tbloader#36 Has anything changed that might cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to unify godot-cpp scons builds with upstream godot + godotengine/godot#66242 .
Some notes and differences:
editorandtemplate_debugbuilds are interchangeable from the library perspective, but might be different in your own library.The default target is for this reason
template_debug.You can target both by just using the
debugfeature tag in thegdextensionfile.You can target each specifically via the
editorandstandalone.debugfeature tags.editorbuilds have the extraTOOLS_ENABLEDdefine (unused by the library itself).separate_debug_symbolsis missing.Draft status:
separate_debug_symbolsis missing.demoI think it's good for now. We can always change this latergdextensionusestemplate-debugtargets for botheditorandtemplate-debug(do we want to split them?).SCons: Unify tools/target build type configuration godot#66242Merged.consolidateLike above, can be done later.standalone.debugtotemplate.debugupstream?