Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Scons boilerplate for building projects. Android, iOS builds. #691

Merged
merged 3 commits into from
Jun 13, 2022
Merged

[3.x] Scons boilerplate for building projects. Android, iOS builds. #691

merged 3 commits into from
Jun 13, 2022

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Feb 10, 2022

3.x version of #636

@Faless Faless added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Feb 10, 2022
@Faless Faless added this to the 4.0 milestone Feb 10, 2022
@Faless Faless marked this pull request as draft February 10, 2022 05:10
@Faless
Copy link
Contributor Author

Faless commented Feb 10, 2022

Might still need a small fix for iOS simulator

@Faless Faless marked this pull request as ready for review February 10, 2022 06:37
@Faless
Copy link
Contributor Author

Faless commented Feb 10, 2022

Might still need a small fix for iOS simulator

No, 3.x version was okay.

Calinou
Calinou approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me (although I haven't tested it locally and don't have much experience working with GDNative).

@akien-mga akien-mga modified the milestones: 4.0, 3.5 Apr 25, 2022
@akien-mga akien-mga changed the title [3.x] Scons boilerplate for building projects. Andoird, iOS builds. [3.x] Scons boilerplate for building projects. Android, iOS builds. Apr 25, 2022
@akien-mga
Copy link
Member

Would be good if @BastiaanOlij @m4gr3d could test this against their GDNative plugins, to make sure that it's not too major a disruption for 3.x users.

If we can make it so that it still supports the "old" style of building projects with their own full blown SCons file (i.e. the syntax to build the library only doesn't change), then I think it should be fine for 3.5.

This was referenced Apr 27, 2022
Merged
Open
@Faless Faless mentioned this pull request Jun 8, 2022
Merged
5 tasks
akien-mga
akien-mga approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit ac572d5 into godotengine:3.x Jun 13, 2022
@akien-mga
Copy link
Member

Thanks!

@Faless Faless mentioned this pull request Jun 14, 2022
Closed
@aaronfranke aaronfranke mentioned this pull request Jun 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @akien-mga @Calinou