Add a separate setup-godot-cpp github action. #1656
+63
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the godot-cpp meeting. This action is specifically intended to be used by dependants of godot-cpp, to set up godot-cpp in their own github workflows. A follow-up PR will use this github action in godot-cpp-template (edit: godotengine/godot-cpp-template#70).
There are quite a few differences to godot-cpp-template's setup steps. I don't know if they started the same but diverged later, or if godot-cpp-template has always made different decisions from godot-cpp itself. Here is godot-cpp-template's version for reference.
I based my implementation mostly on godot-cpp. Here are the key differences I see:
actions/setup-java@v4
andandroid-actions/setup-android@v3
are used on godot-cpp-template, whilenttld/setup-ndk@v1
is used on godot-cpp.godot-cpp-template
, while they are explicitly disabled ongodot-cpp
. This was recently decided in [Web] Don't cache emsdk #1639 and should not be reverted.build-essential pkg-config
on linux. godot-cpp only installs these dependencies for the cmake build. I conclude they may not be needed for scons builds.I think that's all of the differences, though the github runner shall smite my PR if it's not compatible anymore.