Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to/from dict helpers for PropertyInfo/MethodInfo #1443

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Implement to/from dict helpers for PropertyInfo/MethodInfo #1443

merged 1 commit into from
Apr 24, 2024

Conversation

Naros
Copy link
Contributor

@Naros Naros commented Apr 19, 2024

Others may appreciate these rather than create their own implementations.

@Naros Naros requested a review from a team as a code owner April 19, 2024 19:22
@Naros Naros force-pushed the property-method-dict-helpers branch 2 times, most recently from baadca7 to 78bebbd Compare April 19, 2024 19:26
@Naros Naros force-pushed the property-method-dict-helpers branch from 78bebbd to 2a041b5 Compare April 20, 2024 22:50
dsnopek
dsnopek approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

This code appears to match the implementations of the same methods in Godot itself.

@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Apr 23, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 23, 2024
@dsnopek dsnopek merged commit d304f12 into godotengine:master Apr 24, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.2 in PR #1465

@dsnopek
Copy link
Collaborator

dsnopek commented May 17, 2024

Cherry-picked for 4.1 in PR #1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Naros @dsnopek @AThousandShips