Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce template syntax typename over class #1409

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Enforce template syntax typename over class #1409

merged 1 commit into from
Apr 2, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Mar 10, 2024

Companion PR for godotengine/godot#89270

@Repiteo Repiteo requested a review from a team as a code owner March 10, 2024 21:07
@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality waiting for Godot This issue needs a Godot Engine improvement to be solved and removed waiting for Godot This issue needs a Godot Engine improvement to be solved labels Mar 11, 2024
dsnopek
dsnopek approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The Godot PR has been merged and this looks good to me :-)

@dsnopek dsnopek merged commit 44d78ec into godotengine:master Apr 2, 2024
12 checks passed
@dsnopek dsnopek mentioned this pull request Apr 2, 2024
Merged
@dsnopek
Copy link
Collaborator

dsnopek commented Apr 8, 2024

Cherry-picked for 4.1 in PR #1411

@dsnopek
Copy link
Collaborator

dsnopek commented Apr 8, 2024

Cherry-picked for 4.2 in PR #1410

@Repiteo Repiteo deleted the class-to-typename branch April 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Repiteo @dsnopek @AThousandShips