-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for getting argument count from Callable
s
#1375
Add support for getting argument count from Callable
s
#1375
Conversation
6789ada
to
f7674a1
Compare
Temporarily updated the artifact checkout to point to the other PR's branch to verify the changes, will revert once the main repo is updated |
98ebc78
to
6974479
Compare
Simply pushed the changes to the interface completely, the extension and header, covering the changes in the base PR and general changes If there's a different procedure I'll change 🙂 |
I usually copy over the specific We usually only update |
At least the changes to |
Realized the |
6974479
to
4dadeaa
Compare
4dadeaa
to
134450c
Compare
134450c
to
2b526c9
Compare
Dropped the |
2b526c9
to
386293b
Compare
386293b
to
fb79d5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great to me :-)
(Extra thanks for adding to the automated tests ❤️ )
Thank you! Was a good excersie in figuring out that they worked correctly |
Copied over just the specific api changes from this PR and not a general update, if the latter is desired I'll just copy that over instead
Since GDExtension supports vararg methods and uses the number of specified arguments (I think, haven't tested extensively) and unsure how we should handle that on this side