Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting argument count from Callables #1375

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

AThousandShips
Copy link
Member

Copied over just the specific api changes from this PR and not a general update, if the latter is desired I'll just copy that over instead

Since GDExtension supports vararg methods and uses the number of specified arguments (I think, haven't tested extensively) and unsure how we should handle that on this side

@AThousandShips AThousandShips added enhancement This is an enhancement on the current functionality waiting for Godot This issue needs a Godot Engine improvement to be solved topic:gdextension This relates to the new Godot 4 extension implementation labels Jan 28, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Jan 28, 2024
@AThousandShips
Copy link
Member Author

Temporarily updated the artifact checkout to point to the other PR's branch to verify the changes, will revert once the main repo is updated

@AThousandShips AThousandShips force-pushed the the_angry_count_cpp branch 4 times, most recently from 98ebc78 to 6974479 Compare January 30, 2024 17:46
@AThousandShips
Copy link
Member Author

Simply pushed the changes to the interface completely, the extension and header, covering the changes in the base PR and general changes

If there's a different procedure I'll change 🙂

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 31, 2024

I usually copy over the specific gdextension_interface.h changes that a PR is related to and skip any others, since we end up with different PRs adding support for each feature. Not sure this is the best process, though, it's just what I've personally done in the past.

We usually only update extension_api.json when a Godot release happens. Are those changes necessary for the tests to pass? If not, I'd personally just leave that out. If so, I guess we'll come up with something. :-)

@AThousandShips
Copy link
Member Author

At least the changes to Callable will confirm and restore 🙂

@AThousandShips
Copy link
Member Author

Realized the Callable changes weren't required as they are only tested on the C++ side, so will revert the API side

@AThousandShips
Copy link
Member Author

Dropped the ScriptInstance part and leaving it for dedicated updates of the API, as it's not utilized in any testing here, and also no not part of the relevant PR

@AThousandShips AThousandShips removed the waiting for Godot This issue needs a Godot Engine improvement to be solved label Mar 13, 2024
@AThousandShips AThousandShips marked this pull request as ready for review March 13, 2024 21:40
@AThousandShips AThousandShips requested a review from a team as a code owner March 13, 2024 21:40
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great to me :-)

(Extra thanks for adding to the automated tests ❤️ )

@dsnopek dsnopek merged commit 916b4ff into godotengine:master Mar 14, 2024
12 checks passed
@AThousandShips AThousandShips deleted the the_angry_count_cpp branch March 14, 2024 14:15
@AThousandShips
Copy link
Member Author

Thank you!

Was a good excersie in figuring out that they worked correctly

@akien-mga akien-mga removed this from the 4.x milestone Jul 22, 2024
@akien-mga akien-mga added this to the 4.3 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants