-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix building as static library or xcframework, add iOS config and xcframework build script to the test project. #1302
Conversation
c5d29d3
to
30704d8
Compare
Thanks! Having to add the dummy arguments to However, it looks like this needs to be rebased - there's a conflict |
Might be good to add a comment to explain what these dummy arguments are for. @dsnopek This shouldn't be cherry-picked for 4.1 unless godotengine/godot#84493 also is, but for now it's unclear whether it will be merged in time even for 4.2. |
…nd xcframework build script to the test project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
CI is failing on the Linux (GCC) build, for some reason it doesn't want to pick up a runner and seems to be stuck on running the unit tests. Two attempts failed the same way. This doesn't seem due to this PR specifically, it was likely just opened at a time where GHA was misbehaving and now it's stuck in a bad state. Other tests passed so this should be mergeable. |
Thanks! |
new
/delete
operations to avoid conflicts with the equivalent engine symbols when static linking (on iOS both engine and extension can be static library).example.gdextension
config and build script for iOS.xcframework
(device + simulator) build.example.gdextension
.Bugsquad edit: Depends on godotengine/godot#84493