Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash in ClassDB::deinitialize due to usage of invalid iterator. #1260

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fixes crash in ClassDB::deinitialize due to usage of invalid iterator. #1260

merged 1 commit into from
Oct 5, 2023

Commits on Oct 5, 2023

  1. Fixes crash in ClassDB::deinitialize due to usage of invalid iterator. 

    After the removed call to `std::vector::erase` all iterators,
`i` included, are invalidated and therefore this code has undefined
behavior (which can or not lead to a crash).
This change delays the removal of class names from
`class_register_order` to after having gone through it's content,
removing the undefined behavior.
    @Klaim
    Klaim committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5134c82 View commit details
    Browse the repository at this point in the history