Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure const correctness for wrappers #1233

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 6, 2023

The pointer validity for casting is broken with multiple inheritance and possibly other situations, this ensures that pointers returned match the constness of the relevant functions

I'm assuming these are internal and don't affect compatibility in any way, most users likely aren't using multiple inheritance for interfaces etc. so probably why it has gone unnoticed

@AThousandShips AThousandShips added bug This has been identified as a bug cherrypick:4.1 labels Sep 6, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Sep 6, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 6, 2023 17:42
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me and matches how Godot handles similar methods.

@dsnopek dsnopek merged commit 82e960a into godotengine:master Sep 7, 2023
@AThousandShips AThousandShips deleted the wrapper_fix branch September 7, 2023 13:28
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Inheritance breaks when _to_string function is declared.
3 participants