Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCons] Add option to generate a compilation database. #1189

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[SCons] Add option to generate a compilation database. #1189

merged 1 commit into from
Jul 31, 2023

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Jul 22, 2023

Lighter version of #1171.

@Faless Faless added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jul 22, 2023
@Faless Faless requested a review from a team as a code owner July 22, 2023 18:06
adamscott
adamscott approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Thanks @Faless for this lightweight version.

@adamscott adamscott mentioned this pull request Jul 23, 2023
Closed
dsnopek
dsnopek approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks good to me and seems to work in some quick local testing :-)

@dsnopek dsnopek merged commit d168dd0 into godotengine:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @dsnopek @adamscott