Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSVC] Force UTF-8 encoding. #1175

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[MSVC] Force UTF-8 encoding. #1175

merged 1 commit into from
Jul 14, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 11, 2023 •
edited by dsnopek
Loading

Fixes #1174
Fixes #1177

@bruvzg bruvzg added bug This has been identified as a bug platform:windows topic:buildsystem Related to the buildsystem or CI setup topic:gdextension This relates to the new Godot 4 extension implementation labels Jul 11, 2023
@bruvzg bruvzg requested a review from a team as a code owner July 11, 2023 13:11
@bruvzg bruvzg changed the title [MSVC] Force UTf-8 encoding. [MSVC] Force UTF-8 encoding. Jul 11, 2023
@bruvzg bruvzg force-pushed the msvc_force_utf8 branch from fdfb3ac to d1aeba7 Compare July 11, 2023 13:12
akien-mga
akien-mga approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's consistent with upstream Godot.

@dsnopek dsnopek mentioned this pull request Jul 13, 2023
Closed
@dsnopek
Copy link
Collaborator

dsnopek commented Jul 14, 2023 •
edited
Loading

Given that this is approved by Remi as matching what we have in Godot, and it is confirmed by a user to fix the issue on issue #1177, I'm going be bold and hit the merge button :-)

Thanks!

@dsnopek dsnopek merged commit a9209ce into godotengine:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug platform:windows topic:buildsystem Related to the buildsystem or CI setup topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
No milestone
3 participants
@bruvzg @dsnopek @akien-mga