-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Object::notification
order (cpp-bindings)
#1151
Conversation
1a802d1
to
c2252a8
Compare
881af45
to
e420642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bd8fa1c
to
379e7a1
Compare
I did try to solve the problem of the failed check, but unfortunately I wasn't yet able to pinpoint the exact cause.
Edit: it was a missing |
cc10911
to
9ba055f
Compare
I tested this locally together with the Godot PR, and it all worked! However, we'll need to wait for the Godot PR to be merged before the CI will pass here. |
45b75cd
to
9206ae9
Compare
Looking great! I manually tested together with the latest Godot PR, and everything seems to be working fine. :-) I'd be happy to approve this after the Godot change is merged, and CI is passing here (the automated tests pass locally for me). |
9206ae9
to
8ac33d3
Compare
For the notification-order to work correctly, it is necessary to allow the `p_reversed` argument to be used within cpp. This PR changes the necessary bindings.
8ac33d3
to
c2d99fd
Compare
With godotengine/godot#78634 merged in the main repository, now all checks have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
For the notification-order to work correctly, it is necessary to allow the
p_reversed
argument to be used within cpp. This PR changes the necessary bindings.Object::notification
order godot#78634This is my first cpp-api change, so please review carefully.