Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Object::notification order (cpp-bindings) #1151

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Jun 24, 2023

For the notification-order to work correctly, it is necessary to allow the p_reversed argument to be used within cpp. This PR changes the necessary bindings.

This is my first cpp-api change, so please review carefully.

@Sauermann Sauermann requested a review from a team as a code owner June 24, 2023 18:06
@Sauermann Sauermann added the bug This has been identified as a bug label Aug 7, 2023
@Sauermann Sauermann force-pushed the fix-notification-order branch 3 times, most recently from 881af45 to e420642 Compare August 8, 2023 09:58
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

include/godot_cpp/classes/wrapped.hpp Outdated Show resolved Hide resolved
include/godot_cpp/core/class_db.hpp Outdated Show resolved Hide resolved
@Sauermann Sauermann force-pushed the fix-notification-order branch 2 times, most recently from bd8fa1c to 379e7a1 Compare August 9, 2023 11:46
@Sauermann
Copy link
Contributor Author

Sauermann commented Aug 9, 2023

I did try to solve the problem of the failed check, but unfortunately I wasn't yet able to pinpoint the exact cause.
On Windows the backtrace was more verbose than on Linux, so I include it here.

================================================================
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.2.dev.custom_build (e7a6baecfbf86afb236d12b1b383c37305e4ee81)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] ???
[1] <couldn't map PC to fn name>
[2] <couldn't map PC to fn name>
[3] <couldn't map PC to fn name>
[4] GDExtension::initialize_library (H:\dev\godot\core\extension\gdextension.cpp:536)
[5] GDExtensionManager::initialize_extensions (H:\dev\godot\core\extension\gdextension_manager.cpp:125)
[6] Main::setup2 (H:\dev\godot\main\main.cpp:2520)
[7] Main::setup (H:\dev\godot\main\main.cpp:2017)
[8] widechar_main (H:\dev\godot\platform\windows\godot_windows.cpp:165)
[9] _main (H:\dev\godot\platform\windows\godot_windows.cpp:204)
[10] main (H:\dev\godot\platform\windows\godot_windows.cpp:218)
[11] WinMain (H:\dev\godot\platform\windows\godot_windows.cpp:232)
[12] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[13] <couldn't map PC to fn name>
-- END OF BACKTRACE --
================================================================

Edit: it was a missing LOAD_PROC_ADDRESS. Fixed it.

@Sauermann Sauermann force-pushed the fix-notification-order branch 2 times, most recently from cc10911 to 9ba055f Compare August 10, 2023 09:21
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 16, 2023

I tested this locally together with the Godot PR, and it all worked! However, we'll need to wait for the Godot PR to be merged before the CI will pass here.

@Sauermann Sauermann force-pushed the fix-notification-order branch 2 times, most recently from 45b75cd to 9206ae9 Compare August 24, 2023 22:33
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 25, 2023

Looking great! I manually tested together with the latest Godot PR, and everything seems to be working fine. :-) I'd be happy to approve this after the Godot change is merged, and CI is passing here (the automated tests pass locally for me).

For the notification-order to work correctly, it is necessary to
allow the `p_reversed` argument to be used within cpp.
This PR changes the necessary bindings.
@Sauermann
Copy link
Contributor Author

With godotengine/godot#78634 merged in the main repository, now all checks have passed.

@Sauermann Sauermann added this to the 4.2 milestone Aug 30, 2023
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@dsnopek dsnopek merged commit 9a6c741 into godotengine:master Aug 30, 2023
11 checks passed
@Sauermann Sauermann deleted the fix-notification-order branch August 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants