-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support additional doc comment markdown #1017
base: master
Are you sure you want to change the base?
Conversation
fce5645
to
fe1e8b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really nice to get done! i think overall it looks pretty good, largely just some style questions here and there. it's a bit unfortunate that the diff is confused here though
fe1e8b8
to
e00bd0c
Compare
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1017 |
e00bd0c
to
a842f82
Compare
a842f82
to
a307ec5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving this part, really great work!
I also like how you emulate absent features like superscripts and list bullets 👍
8c6d678
to
2cfe302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Upon closer look, the code is of really high quality, and the implementation looks very solid. I mostly pointed out some smaller formatting/readability issues. Could you also run rustfmt?
I'll also try to find some time to test it in action 🙂
52e0433
to
7e07fa1
Compare
Addressed the review comments and rebased onto the main branch. |
Apparently I borked the ordered list incremention. Whoops. |
7e07fa1
to
9f10a74
Compare
Should be good now. |
Simulates formatting that Godot does not natively support in its limited BBCode implementation, such as lists and footnotes, as best as possible. Also fixes godot-rust#811 as paragraphs are correctly formatted, without excessive line breaks.
9f10a74
to
3996b71
Compare
Simulates formatting that Godot does not natively support in its limited BBCode implementation, such as lists and footnotes, as best as possible.
Also fixes #811 as paragraphs are correctly formatted, without excessive line breaks.
Markup
Output