Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set a proper guard in case of no speaking animations #488

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Conversation

BHSDuncan
Copy link
Collaborator

… the upper limit check for the speaking index

… the upper limit check for the speaking index
@BHSDuncan BHSDuncan requested review from dploeger and StraToN and removed request for dploeger February 4, 2022 22:11
Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks. 🎁

@StraToN
Copy link
Collaborator

StraToN commented Feb 6, 2022

Oh indeed, that was all wrong! Thanks a lot!

@StraToN StraToN changed the title fix: set a proper guard in case of no speaking animations and correct… fix: set a proper guard in case of no speaking animations Feb 6, 2022
@StraToN StraToN merged commit 326618d into develop Feb 6, 2022
@StraToN StraToN deleted the issue-98 branch February 6, 2022 10:24
balloonpopper pushed a commit to balloonpopper/escoria-demo-game that referenced this pull request Feb 13, 2022
…ria#488)

+ correct the upper limit check for the speaking index
Co-authored-by: Duncan Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants