Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dialog trees, documentation and default font #166

Merged
merged 3 commits into from
May 22, 2018

Conversation

fleskesvor
Copy link
Collaborator

Adds font with better Unicode support, which finally fixes #40.

I'm not 100% sure how to best respect the license (SIL Open Font License), but I included the original license file and readme in a separate font directory and put a note in our readme. Do you know if this is the best way, @StraToN, or should we ask Akien?

@mjtorn
Copy link
Collaborator

mjtorn commented May 16, 2018 via email

@fleskesvor
Copy link
Collaborator Author

Tested in our jam game, it works with colors and shadow-as-outline.

Thanks for testing. 🙂

IIRC the .tres files are project-specific, but I always find myself searching
for https://godotengine.org/qa/20870/how-do-you-bring-fonts-into-godot-3-0

Should that maybe be pointed out or have a pointer to the official docs

Good point. I will add a small doc on using and customizing dialogue, including fonts.

@akien-mga
Copy link

I'm not 100% sure how to best respect the license (SIL Open Font License), but I included the original license file and readme in a separate font directory and put a note in our readme. Do you know if this is the best way, @StraToN, or should we ask Akien?

All good :) 👍

@StraToN
Copy link
Collaborator

StraToN commented May 16, 2018

All good for me as well. 👍

@fleskesvor
Copy link
Collaborator Author

Thanks guys. ❤️

My second commit should address #41. It's not perfect, but it's much better than what we have.

@fleskesvor fleskesvor changed the title Use font with better language support Improve dialog trees, documentation and default font May 19, 2018
@fleskesvor
Copy link
Collaborator Author

I improved the default dialog tree further and added some documentation on designing dialogs. I forgot that @mjtorn had written a section on designing speech dialog in a different chapter of the doc, but since most of that is more on configuration, I think I will move that into my TODO and cut the instructions that are duplicated.

@fleskesvor fleskesvor force-pushed the utf-8-font branch 3 times, most recently from 1ef3cf2 to 8a098d9 Compare May 21, 2018 21:18
@fleskesvor
Copy link
Collaborator Author

I moved the section on speech dialog into the new document on dialogs, and adapted it to not repeat the things from the previous section. Anyone want to look over the changes before it's merged?

@fleskesvor fleskesvor force-pushed the utf-8-font branch 3 times, most recently from a8fca89 to 24cb316 Compare May 21, 2018 22:09
@fleskesvor fleskesvor merged commit 933e949 into godot-escoria:master May 22, 2018
balloonpopper pushed a commit to balloonpopper/escoria-demo-game that referenced this pull request Mar 10, 2022
StraToN pushed a commit that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cyrillic symbols in esc files
4 participants