-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dialog trees, documentation and default font #166
Conversation
Tested in our jam game, it works with colors and shadow-as-outline.
IIRC the .tres files are project-specific, but I always find myself searching
for https://godotengine.org/qa/20870/how-do-you-bring-fonts-into-godot-3-0
Should that maybe be pointed out or have a pointer to the official docs
if they explain the thing?
Either way, good work, much appreciated!
…On Tue, May 15, 2018 at 02:14:00PM -0700, Eivind wrote:
Adds font with better [Unicode support](https://developers.googleblog.com/2016/10/an-open-source-font-system-for-everyone.html), which finally fixes #40.
I'm not 100% sure how to best respect the license (SIL Open Font License), but I included the original license file and readme in a separate font directory and put a note in our readme. Do you know if this is the best way, @StraToN, or should we ask Akien?
You can view, comment on, or merge this pull request online at:
#166
-- Commit Summary --
* Use font with better language support
-- File Changes --
M README.md (4)
M device/demo/ui/dd_default.tscn (59)
R device/demo/ui/dialog_default.tscn (44)
M device/ui/dialog_player.tscn (3)
A device/ui/fonts/LICENSE_OFL.txt (92)
A device/ui/fonts/NotoSans-Regular.ttf (0)
A device/ui/fonts/README (11)
-- Patch Links --
https://github.com/godotengine/escoria/pull/166.patch
https://github.com/godotengine/escoria/pull/166.diff
|
Thanks for testing. 🙂
Good point. I will add a small doc on using and customizing dialogue, including fonts. |
All good :) 👍 |
All good for me as well. 👍 |
Thanks guys. ❤️ My second commit should address #41. It's not perfect, but it's much better than what we have. |
I improved the default dialog tree further and added some documentation on designing dialogs. I forgot that @mjtorn had written a section on designing speech dialog in a different chapter of the doc, but since most of that is more on configuration, I think I will move that into my TODO and cut the instructions that are duplicated. |
1ef3cf2
to
8a098d9
Compare
I moved the section on speech dialog into the new document on dialogs, and adapted it to not repeat the things from the previous section. Anyone want to look over the changes before it's merged? |
a8fca89
to
24cb316
Compare
Adds font with better Unicode support, which finally fixes #40.
I'm not 100% sure how to best respect the license (SIL Open Font License), but I included the original license file and readme in a separate font directory and put a note in our readme. Do you know if this is the best way, @StraToN, or should we ask Akien?