feat: Added print command to print output at any debug level #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloonpopper
requested review from
StraToN,
BHSDuncan and
dploeger
as code owners
StraToN
approved these changes
Apr 4, 2022
BHSDuncan
approved these changes
Apr 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current debug command is restricted to "log level = debug". This means that you can't use it to do your own debugging if you use a different log level.
This PR adds a print command. It needs to be a separate command to debug as debug is used by the engine to print all the internal engine state. As a result, if debug was allowed to print at any log level, you would end up with engine debugging messages even at "info" level.