Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-launch leaks a process #268

Closed
giuseppe opened this issue Aug 24, 2021 · 4 comments · Fixed by #273
Closed

dbus-launch leaks a process #268

giuseppe opened this issue Aug 24, 2021 · 4 comments · Fixed by #273

Comments

@giuseppe
Copy link
Contributor

the function getSessionBusAddress() calls getSessionBusPlatformAddress() if there is no dbus session already active.

getSessionBusPlatformAddress() in turn runs dbus-launch which leaks the process.

Issues reported here: containers/podman#9727

Would it make sense to have a way to disable the getSessionBusPlatformAddress() fallback and avoid running dbus-launch?

@jsouthworth
Copy link
Member

I think it does. I believe @fawkesley and @jessevdk have worked in this area of the code before. Do either of you have an opinion here?

@giuseppe
Copy link
Contributor Author

Can we move this forward? I can open a PR if there is an agreement on the way to fix it.

@jsouthworth
Copy link
Member

If you have a PR then I'll review it.

giuseppe added a commit to giuseppe/dbus that referenced this issue Oct 18, 2021
SessionBusPrivate automatically launches dbus-launch when the other
detection mechanisms fail.  SessionBusPrivateNoAutoStartup returns an
error without executing a new process, so that it is not leaked.

Closes: godbus#268

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
Copy link
Contributor Author

If you have a PR then I'll review it.

opened a PR here: #273

jsouthworth pushed a commit that referenced this issue Oct 26, 2021
SessionBusPrivate automatically launches dbus-launch when the other
detection mechanisms fail.  SessionBusPrivateNoAutoStartup returns an
error without executing a new process, so that it is not leaked.

Closes: #268

Signed-off-by: Giuseppe Scrivano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants