Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub strings properly #3

Closed
godber opened this issue May 2, 2015 · 1 comment
Closed

Scrub strings properly #3

godber opened this issue May 2, 2015 · 1 comment

Comments

@godber
Copy link
Owner

godber commented May 2, 2015

The strings returned by the ANTLR grammar currently have a bug that requires that we manually scrub the string to be PDS compliant. This scrubbing should strip all new lines and redundant whitespace.

See the issue in the grammar for details: godber/pds3_grammar/issues/2
godber added a commit that referenced this issue May 3, 2015
@godber
cleaned up strings, refs #3
7c3c133
godber added a commit that referenced this issue May 3, 2015
@godber
Merge pull request #4 from godber/issue#3-scrub-strings
676e7f1 
cleaned up strings, refs #3
@godber
Copy link
Owner Author

godber commented May 3, 2015

I think 7c3c133 covers everything that needs to be done to strings.

@godber godber closed this as completed May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@godber