Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model factory #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jonykalavera
Copy link

@jonykalavera jonykalavera commented Apr 9, 2022

WIP to retrieve a model instance from the avsc file path.

#37

@ffinfo
Copy link
Contributor

ffinfo commented Apr 21, 2022

@jonykalavera Nice change to add this. Can you add some testing for this to be sure that this stays working?

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #36 (c7d1628) into main (5388e41) will decrease coverage by 2.89%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   89.08%   86.18%   -2.90%     
==========================================
  Files           2        2              
  Lines         174      181       +7     
==========================================
+ Hits          155      156       +1     
- Misses         19       25       +6     
Impacted Files Coverage Δ
src/pydantic_avro/avro_to_pydantic.py 77.77% <14.28%> (-4.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5388e41...c7d1628. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants