Add service principal resource #1074
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthony1128
force-pushed
the
feature/service-principal-resource
branch
from
7de3333 to
428b8d0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aws-lambda/src/databricks_cdk/resources/service_principals/service_principal_secrets.py
Fixed
Show fixed
Hide fixed
added 9 commits
December 18, 2024 15:04
…pported Node runtime)
| account_client = get_account_client() | ||
|
|
||
| if physical_resource_id: | ||
| return update_service_principal_secrets(properties, physical_resource_id, account_client) |
There was a problem hiding this comment.
in case have a use case and we want to recreate the secret again, will we have to delete it first?
| ) | ||
|
|
||
|
|
||
| def update_service_principal_secrets( |
There was a problem hiding this comment.
I would change the function name here, because we are not updating. Maybe get_service_principal_secrets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.