Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new permissions support for volumes #1061

Merged

Conversation

DaanRademaker
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ebbe764) 62.64% compared to head (cc189ec) 63.14%.

Files Patch % Lines
...ks_cdk/resources/permissions/volume_permissions.py 52.38% 10 Missing ⚠️
aws-lambda/src/databricks_cdk/resources/handler.py 20.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
+ Coverage   62.64%   63.14%   +0.49%     
==========================================
  Files          36       38       +2     
  Lines        1847     1910      +63     
==========================================
+ Hits         1157     1206      +49     
- Misses        690      704      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanRademaker DaanRademaker force-pushed the add_support_for_volumes branch from 7893747 to dc250bb Compare November 28, 2023 08:46
@DaanRademaker DaanRademaker force-pushed the add_support_for_volumes branch from dc250bb to cc189ec Compare November 28, 2023 08:56
@dan1elt0m dan1elt0m self-assigned this Nov 28, 2023
@DaanRademaker DaanRademaker merged commit 7d00280 into godatadriven:main Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants