adjust typescript to new response

godatadriven · Dec 19, 2024 · 430afb7 · 430afb7
1 parent d8e2bd3
commit 430afb7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/typescript/src/resources/service-principals/servicePrincipal.ts b/typescript/src/resources/service-principals/servicePrincipal.ts
@@ -2,7 +2,7 @@ import { CustomResource } from "aws-cdk-lib";
 import { Construct } from "constructs";
 
 export interface ComplexValue {
-    // TODO: Add more fields according to the actual schema
+    // TODO: Add more fields according to the actual schema, refert to https://databricks-sdk-py.readthedocs.io/en/latest/dbdataclasses/iam.html#databricks.sdk.service.iam.ComplexValue
     value?: string,
 }
 
@@ -15,7 +15,7 @@ export interface ServicePrincipalSettings {
     groups?: ComplexValue[]
     id?: string
     roles?: ComplexValue[]
-    // TODO: Add support for a "schemas" field
+    // TODO: Add support for a "schemas" field, refer to https://databricks-sdk-py.readthedocs.io/en/latest/dbdataclasses/iam.html#databricks.sdk.service.iam.ServicePrincipalSchema
 }
 
 export interface ServicePrincipalProperties {

diff --git a/typescript/src/resources/service-principals/servicePrincipalSecrets.ts b/typescript/src/resources/service-principals/servicePrincipalSecrets.ts
@@ -20,4 +20,12 @@ export class ServicePrincipalSecrets extends CustomResource {
             }
         });
     }
+
+    public secretsManagerArn(): string {
+        return this.getAttString("secrets_manager_arn");
+    }
+
+    public secretsManagerName(): string {
+        return this.getAttString("secrets_manager_name");
+    }
 }