-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disappearing buttons inside of Services blocks #2613
Fix disappearing buttons inside of Services blocks #2613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test must be changed
coblocks/src/blocks/services/test/services.cypress.js
Lines 91 to 107 in 0206e8e
/** | |
* Test that we can add a services block to the content, enable | |
* action buttons and are able to successfully save the block without errors. | |
*/ | |
it( 'Test services block saves with action buttons enabled.', function() { | |
helpers.addBlockToPost( 'coblocks/services', true ); | |
cy.get( 'div.wp-block-button' ).should( 'not.exist' ); | |
helpers.toggleSettingCheckbox( /display buttons/i ); | |
cy.get( '.wp-block-buttons' ).should( 'have.length', 2 ); | |
helpers.savePage(); | |
helpers.checkForBlockErrors( 'coblocks/services' ); | |
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I was not able to break the block, or trigger a deprecation error. Should be good to release.
Description
Removed 'Display button' toggle from the services and service blocks.
Link to issue WPEX-3677
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Manual regression testing
Acceptance criteria
'Display button' toggle should be completely removed after deciding to allow users to place buttons within the inner blocks if they choose.
Checklist: