Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve logging for downloader and aggregator #481

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: improve logging for downloader and aggregator #481

merged 2 commits into from
Oct 18, 2023

Conversation

bernhardreiter
Copy link
Member

  • use full name for printing out the used logfile for the downloader.
  • for debug or verbose, log the timeintervall that will be used for downloader and aggregator. (The checker has this as part of its output already.)

@bernhardreiter
fix: improve logging for downloader and aggregator
3923dc7 
 * use full name for printing out the used logfile for the downloader.
 * for debug or verbose, log the timeintervall that will be used
   for downloader and aggregator. (The checker has this as part
   of its output already.)
s-l-teichmann
s-l-teichmann approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JanHoefelmeyer
JanHoefelmeyer approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@JanHoefelmeyer JanHoefelmeyer merged commit 81edb6c into main Oct 18, 2023
@bernhardreiter bernhardreiter mentioned this pull request Oct 18, 2023
Closed
@bernhardreiter bernhardreiter deleted the improve_logging2 branch October 18, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bernhardreiter @s-l-teichmann @JanHoefelmeyer