Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info for Req 8-10 if direct url was given and as such no checks were performed. #401

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Add info for Req 8-10 if direct url was given and as such no checks were performed. #401

merged 3 commits into from
Jul 13, 2023

Conversation

JanHoefelmeyer
Copy link
Contributor

Solves #339.

Decided to explicitly give out info both requirements as well as requirement 10 (which also checks the PMD) to make sure to differentiate this case from cases where no check was performed due to misc. reasons.

ThomasJunk
ThomasJunk previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tschmidtb51
tschmidtb51 reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - other than that LGTM and works.

cmd/csaf_checker/processor.go Outdated Show resolved Hide resolved
tschmidtb51
tschmidtb51 previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

s-l-teichmann
s-l-teichmann reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

@s-l-teichmann s-l-teichmann self-requested a review July 13, 2023 13:23
s-l-teichmann
s-l-teichmann approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

ThomasJunk
ThomasJunk approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tschmidtb51
tschmidtb51 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit f05bcd3 into main Jul 13, 2023
@JanHoefelmeyer JanHoefelmeyer deleted the better_error_pmd_url branch July 19, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@tschmidtb51 tschmidtb51 tschmidtb51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanHoefelmeyer @s-l-teichmann @ThomasJunk @tschmidtb51